Skip to content

Small fixes in new parser - #164

Merged
Schamper merged 3 commits into
mainfrom
parser-fixes
Jul 15, 2026
Merged

Schamper merged 3 commits into
mainfrom
parser-fixes

Conversation

@Schamper

Copy link
Copy Markdown
Contributor

Some small fixes I encountered while trying to use the new parser code in dissect.executable.

@Schamper
Schamper requested a review from Miauwkeru July 13, 2026 17:42
@codecov

codecov Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (0edfc10) to head (39f24c3).

Files with missing lines Patch % Lines
dissect/cstruct/parser.py 0.00% 16 Missing ⚠️
dissect/cstruct/lexer.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #164   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         22      22           
  Lines       2700    2719   +19     
=====================================
- Misses      2700    2719   +19     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 14 untouched benchmarks


Comparing parser-fixes (39f24c3) with main (0edfc10)

Open in CodSpeed

Comment thread dissect/cstruct/lexer.py Outdated
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
@Schamper
Schamper requested a review from Miauwkeru July 14, 2026 08:44
Comment thread tests/test_parser.py Outdated
@Schamper
Schamper merged commit c229e3f into main Jul 15, 2026
24 checks passed
@Schamper
Schamper deleted the parser-fixes branch July 15, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants