Skip to content

Update pyproject.toml license settings and minimum python version - #139

Merged
Miauwkeru merged 11 commits into
mainfrom
update-pyproject-toml-file
Sep 24, 2025
Merged

Miauwkeru merged 11 commits into
mainfrom
update-pyproject-toml-file

Conversation

@Miauwkeru

Copy link
Copy Markdown
Contributor
  • Change the minimum python version to 3.10
  • Update deprecated license settings

@Miauwkeru
Miauwkeru requested a review from twiggler September 19, 2025 14:54
@codecov

codecov Bot commented Sep 19, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.01%. Comparing base (f922343) to head (de33074).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   92.98%   93.01%   +0.03%     
==========================================
  Files          21       21              
  Lines        2437     2435       -2     
==========================================
- Hits         2266     2265       -1     
+ Misses        171      170       -1     
Flag Coverage Δ
unittests 93.01% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pyproject.toml Outdated
requires-python = "~=3.9"
license.text = "Apache License 2.0"
requires-python = ">=3.10"
license = "AGPL-3.0-or-later"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong license.

@Miauwkeru
Miauwkeru force-pushed the update-pyproject-toml-file branch from 24bce5c to 67dc222 Compare September 22, 2025 07:54
@Miauwkeru
Miauwkeru force-pushed the update-pyproject-toml-file branch from 059c09f to d14c986 Compare September 23, 2025 13:56

@Schamper Schamper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update required ruff version.

@Miauwkeru
Miauwkeru force-pushed the update-pyproject-toml-file branch from d14c986 to 6d24f97 Compare September 24, 2025 12:40

@Schamper Schamper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dissect/cstruct/types/base.py
63:        # Python 3.9 compat thing for bound type vars

@Miauwkeru
Miauwkeru requested a review from Schamper September 24, 2025 14:42
@Miauwkeru
Miauwkeru merged commit 194b1b5 into main Sep 24, 2025
21 checks passed
@Miauwkeru
Miauwkeru deleted the update-pyproject-toml-file branch September 24, 2025 15:19
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request May 26, 2026
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 4, 2026
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants