Enable adding new AI model #1667
Closed
Manar-Elhabbal7 wants to merge 3 commits intofoss42:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
I've implemented the logic to add new model
Key Changes
Implemented the Add Model feature by returning a proper Model object from
dialog_add_ai_model.dartand removing the relatedTODOcomments .Enhanced
AIModelSelectorDialogby adding an add button for adding new modelsRefactored the dialog to use local state management instead of
FutureBuilderenabling instant UI updates when models are addedI also enhanced the Code Quality & Performance:
Files Edited
lib/screens/common_widgets/ai/dialog_add_ai_model.dartlib/screens/common_widgets/ai/ai_model_selector_dialog.dartlib/screens/common_widgets/ai/ai.dartdemo video
add-newModel.webm
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases._
OS on which you have developed and tested the feature?