fix: prevent crash when filtering collection with AI requests#1659
Open
Fikri-20 wants to merge 2 commits into
Open
fix: prevent crash when filtering collection with AI requests#1659Fikri-20 wants to merge 2 commits into
Fikri-20 wants to merge 2 commits into
Conversation
… substitution Environment variable keys containing regex metacharacters (., *, +, ?, [], etc.) caused FormatException crashes when used in request fields. This fix properly escapes all special characters using RegExp.escape() before building the regex pattern. - Fixed substituteVariables function in lib/utils/envvar_utils.dart - Added comprehensive test cases for special characters, regex metacharacters, and mixed character scenarios - Resolves crash when using environment variables like 'api.key', 'user+id', etc.
The filter ListView force-unwrapped httpRequestModel to access its url, but httpRequestModel is null for APIType.ai requests. Typing anything in the search box with an AI request present caused an immediate crash. Changed to safe navigation with a false fallback so AI requests are matched by name only, consistent with how they are displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1658
Bug
httpRequestModelisnullforAPIType.airequests. The filter ListView was force-unwrapping it to access.url, crashing the app the moment the user types anything in the search box with an AI request in the collection.Fix
Video after the fix
ai-request-crash-sol.mp4
AI requests are now matched by name only, which is correct since they have no HTTP URL.