Skip to content

fix: prevent unbounded terminal log growth #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xar43 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent unbounded terminal log growth #1655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/codegen/codegen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ class Codegen {
case CodegenLanguage.kotlinOkHttp:
return KotlinOkHttpCodeGen().getCode(rM);
case CodegenLanguage.pythonHttpClient:
return PythonHttpClientCodeGen()
.getCode(rM, boundary: boundary ?? getNewUuid());
return PythonHttpClientCodeGen().getCode(
rM,
boundary: boundary ?? getNewUuid(),
);
case CodegenLanguage.pythonRequests:
return PythonRequestsCodeGen().getCode(rM, boundary: boundary);
case CodegenLanguage.rubyFaraday:
Expand Down Expand Up @@ -121,5 +123,6 @@ class Codegen {
case CodegenLanguage.swiftUrlSession:
return SwiftURLSessionCodeGen().getCode(rM);
}
return null;
}
}
18 changes: 17 additions & 1 deletion lib/providers/terminal_providers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,30 @@ class TerminalController extends StateNotifier<TerminalState> {
TerminalController() : super(TerminalState(entries: <TerminalEntry>[]));

static const _uuid = Uuid();
static const int _maxEntries = 1000;

String _newId() => _uuid.v4();

void clear() {
state = TerminalState(entries: <TerminalEntry>[]);
}

// String append(TerminalEntry entry) {
// final list = [entry, ...state.entries];
// state = TerminalState(entries: list);
// return entry.id;
// }

String append(TerminalEntry entry) {
final list = [entry, ...state.entries];
final currentEntries = state.entries;

final List<TerminalEntry> list;
if (currentEntries.length >= _maxEntries) {
list = [entry, ...currentEntries.take(_maxEntries - 1)];
} else {
list = [entry, ...currentEntries];
}

state = TerminalState(entries: list);
return entry.id;
}
Expand Down Expand Up @@ -221,5 +236,6 @@ class TerminalController extends StateNotifier<TerminalState> {
final s = e.system!;
return s.message;
}
return null;
}
}
Loading