fix(better_networking): getEnabledRows uses row index, not indexOf (#1441)#1635
Open
AyushCoder9 wants to merge 1 commit intofoss42:mainfrom
Open
fix(better_networking): getEnabledRows uses row index, not indexOf (#1441)#1635AyushCoder9 wants to merge 1 commit intofoss42:mainfrom
AyushCoder9 wants to merge 1 commit intofoss42:mainfrom
Conversation
Use index-based filtering instead of indexOf so duplicate NameValueModel rows map to their own enabled flags. Add regression test. Fixes foss42#1441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
getEnabledRowsfiltered rows usingrows.indexOf(element), which always resolves duplicateNameValueModelvalues to the first matching index. That made later duplicate rows incorrectly reuse the first row’s enabled flag.This change uses index-based iteration so each row maps to
isRowEnabledList[i].Also removes the
finalRows == [] ? null : finalRowsbranch so an all-disabled result returns[], matching existing tests.Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?
Test plan
flutter test packages/better_networking/test/utils/http_request_utils_test.dartflutter test packages/better_networking(optional)flutter analyze packages/better_networking