fix(history): avoid duplicate history IDs in persistence#1620
Open
AyushCoder9 wants to merge 1 commit into
Open
fix(history): avoid duplicate history IDs in persistence#1620AyushCoder9 wants to merge 1 commit into
AyushCoder9 wants to merge 1 commit into
Conversation
Ensure history IDs are persisted without duplicates when adding a history request, and add a regression test to lock the behavior. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes duplicate
historyIdspersistence inHistoryMetaStateNotifier.addHistoryRequest.Previously, the provider rebuilt state with the new id and then appended the same id again while writing
historyIds, which could introduce duplicates in storage. This change persistshistoryIdsdirectly from the current state keys so each history id is stored exactly once.Also added a regression test:
test/providers/history_providers_test.dartRelated Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?