#1585 - feat(better_networking): add structured response evaluator#1590
Open
soumyarajbag wants to merge 1 commit intofoss42:mainfrom
Open
#1585 - feat(better_networking): add structured response evaluator#1590soumyarajbag wants to merge 1 commit intofoss42:mainfrom
soumyarajbag wants to merge 1 commit intofoss42:mainfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Closes #1585. Introduces a structured, pure-Dart response evaluation utility in the
better_networkingpackage.The current codebase has no way to programmatically assert API response correctness — only visual inspection via the UI. This PR adds
evaluateResponse(), a pure function that takes anHttpResponseModeland aResponseExpectation, and returns a typedList<EvalResult>—one entry per configured assertion.
Supported assertions:
statusCode— exact match against expected HTTP statusmaxLatency— response time within a duration thresholdrequiredJsonKeys— top-level JSON keys must be present in the bodybodyContains— response body must contain a given substringcontentType— Content-Type header must contain a given substringWhy this approach over a simple logger:
A
voidlogger with side effects is untestable and throws away the result. ReturningList<EvalResult>lets callers (UI, tests, future batcheval) decide what to do with the outcome — display it, aggregate it, or fail a test.
This also serves as the foundation for the multimodal AI & Agent API Eval Framework (Idea #2), where batch evaluation requires running
per-response assertions across datasets.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
test/utils/response_evaluator_test.dart— 25 tests covering all 5 evaluation fields independently, edge cases (null body, null headers,null latency, empty keys list, long body truncation), and combined multi-assertion scenarios including result ordering
OS on which you have developed and tested the feature?