Skip to content

fix: preserve cursor position in JSON body editor #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejaswinisa1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve cursor position in JSON body editor #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions lib/widgets/editor_json.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,38 @@ class _JsonTextFieldEditorState extends State<JsonTextFieldEditor> {
void didUpdateWidget(JsonTextFieldEditor oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.initialValue != widget.initialValue) {
controller.text = widget.initialValue ?? "";
controller.selection =
TextSelection.collapsed(offset: controller.text.length);
final newText = widget.initialValue ?? "";
final oldSelection = controller.selection;

// Avoid unnecessary controller.text assignment; it can reset selection
// during typing. Only update controller text if the incoming value
// differs from what we currently have.
if (controller.text != newText) {
controller.text = newText;
}

// Preserve selection as much as possible by clamping offsets into the
// new text range (prevents out-of-bounds crashes).
final int newLen = controller.text.length;
int clampOffset(int offset) {
if (offset < 0) return 0;
if (offset > newLen) return newLen;
return offset;
}

final baseOffset = clampOffset(oldSelection.baseOffset);
final extentOffset = clampOffset(oldSelection.extentOffset);

if (oldSelection.isCollapsed) {
controller.selection = TextSelection.collapsed(offset: baseOffset);
} else {
controller.selection = TextSelection(
baseOffset: baseOffset,
extentOffset: extentOffset,
affinity: oldSelection.affinity,
isDirectional: oldSelection.isDirectional,
);
}
}
if ((oldWidget.fieldKey != widget.fieldKey) ||
(oldWidget.isDark != widget.isDark)) {
Expand Down