Simplify a negated comparison and an mtree escape write - #383
Merged
Conversation
tar.go compared with !(a == b) where a != b says the same thing. mtreeFilename built each escape sequence as a temporary string before appending it. strings.Builder is an io.Writer, so format straight into it instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
staticcheckquickfix suggestions, both no-ops behaviourally:tar.go:108(QF1001) —!(path.Dir(f.Path) == dir)reads better aspath.Dir(f.Path) != dir.mtreefs.go:106(QF1012) —mtreeFilename()built each escape sequence as a temporary string viafmt.Sprintfbefore appending it.strings.Builderis anio.Writer, so format straight into it withfmt.Fprintfand skip the intermediate allocation.The remaining QF findings are the
opt.cmdStoreOptions.validate()embedded-field selectors (QF1008), one QF1006 infileseed.goand one QF1001 intar.go:54, all left alone as the current spelling is clearer.