Skip to content

Add structural reading port#55

Merged
flyingrobots merged 4 commits into
mainfrom
docs/design-packets-first-doctrine
May 15, 2026
Merged

Add structural reading port#55
flyingrobots merged 4 commits into
mainfrom
docs/design-packets-first-doctrine

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

Summary

  • require design packets before implementation and add the StructuralReadingPort design packet
  • add a Graft-owned StructuralReadingPort with explicit Continuum-native vs translated-substrate evidence status
  • route graft_review impact counts and graft_dead_symbols through the git-warp structural reading adapter without changing public response shapes
  • file follow-up bad-code debt for remaining direct structural WARP read paths

Validation

  • pnpm lint
  • pnpm test (220 files, 1603 tests)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 30 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1bfdf212-05bb-4528-b12e-a3e00afcc978

📥 Commits

Reviewing files that changed from the base of the PR and between a2df7e4 and 6058664.

⛔ Files ignored due to path filters (7)
  • AGENTS.md is excluded by !**/*.md
  • CHANGELOG.md is excluded by !**/*.md
  • METHOD.md is excluded by !**/*.md
  • docs/design/CORE_continuum-structural-reading-port.md is excluded by !**/*.md
  • docs/method/backlog/bad-code/CLEAN_remaining-structural-warp-reads-bypass-structural-reading-port.md is excluded by !**/*.md
  • docs/method/backlog/dependency-dag.dot is excluded by !**/*.dot
  • docs/method/backlog/dependency-dag.svg is excluded by !**/*.svg
📒 Files selected for processing (11)
  • src/mcp/context.ts
  • src/mcp/repo-tool-worker-context.ts
  • src/mcp/server-context.ts
  • src/mcp/tools/dead-symbols.ts
  • src/mcp/tools/structural-review.ts
  • src/ports/structural-reading.ts
  • src/warp/structural-reading-adapter.ts
  • test/unit/mcp/context-guard.test.ts
  • test/unit/ports/structural-reading.test.ts
  • test/unit/warp/structural-reading-adapter.test.ts
  • tests/playback/CORE_v060-bad-code-burndown.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/design-packets-first-doctrine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots
Copy link
Copy Markdown
Owner Author

@codex self-audit found the following issue before merge:

Issue Severity File Lines Evidence Recommended mitigation
Committed import-scan fallback failures are returned as residualPosture: "complete", which overclaims the certainty of a zero-reference structural reading when fallback evidence was unavailable. P2 src/warp/structural-reading-adapter.ts 104-126 The adapter catches fallback errors at line 118 and returns the graph zero-count payload while line 126 still labels the reading complete. Add a deterministic regression test where WARP returns zero and the fallback rejects; update the adapter to return the same public zero-count payload but mark the structural reading residual posture as partial.

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@flyingrobots
Copy link
Copy Markdown
Owner Author

Activity Summary

Issue Severity File Commit SHA Regression coverage Outcome
Reference-count readings reported complete when committed import-scan fallback evidence was unavailable after a zero-count WARP graph reading. P2 src/warp/structural-reading-adapter.ts 6058664 marks reference-count readings partial when committed fallback evidence is unavailable; pnpm test -- --run test/unit/warp/structural-reading-adapter.test.ts Fixed: public zero-count payload is preserved, but the normalized structural reading now reports residualPosture: "partial".

Validation so far:

  • pnpm lint
  • pnpm test -- --run test/unit/ports/structural-reading.test.ts test/unit/warp/structural-reading-adapter.test.ts test/unit/mcp/structural-review-cold-warp.test.ts test/unit/mcp/context-guard.test.ts test/unit/contracts/output-schemas.test.ts

@flyingrobots
Copy link
Copy Markdown
Owner Author

Final Verification Update

Gate Result Evidence
Local lint Pass pnpm lint
Local tests Pass pnpm test -> 220 files, 1604 tests
CI Pass test (20), test (22)
CodeRabbit Pass CodeRabbit status context: Review completed
Review threads Pass 0 unresolved review threads returned by GraphQL
Approvals Blocked 0 latest opinionated reviews; required threshold is >=2 approvals

Merge gate remains locked only on approvals.

@flyingrobots flyingrobots merged commit 5a1c8a0 into main May 15, 2026
3 checks passed
@flyingrobots flyingrobots deleted the docs/design-packets-first-doctrine branch May 15, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant