-
Notifications
You must be signed in to change notification settings - Fork 1
Add WSC store port for causal history recovery #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a4ed532
feat: add generic WSC store port
flyingrobots 9893662
feat: persist accepted submissions in WSC
flyingrobots 68cc77c
feat: persist receipt correlation in WSC
flyingrobots 1d64cd0
feat: persist retention refs in WSC
flyingrobots c1c2135
test: cover retention WSC obstruction posture
flyingrobots 8580ac6
feat: add WSC commit markers
flyingrobots 7fe747a
feat: recover pending submissions from WSC
flyingrobots 6b17054
feat: recover decided submissions from WSC
flyingrobots 0ae88f5
feat: reject incomplete WSC causal history
flyingrobots f2ff254
Merge remote-tracking branch 'origin/main' into stack/jedit-wsc-store…
flyingrobots aa63c1d
Fix: tighten WSC store recovery evidence
flyingrobots 20f7562
Fix: reject conflicting retained WSC evidence
flyingrobots 93b8faf
Fix: reject WSC basis digest mismatches
flyingrobots f32c53d
Fix: clarify WSC digest obstruction docs
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When conflicting retained evidence comes from committed WAL frames rather than a WSC envelope, this new checking constructor is bypassed:
recover_retention_indexstill buildsRecoveredRetentionIndex::default()and inserts directly intomaterial_by_digest/reading_by_id, so a later frame silently overwrites an earlier record with the same material digest or reading id. That leaves WAL doctor/recovery accepting exactly the identity collision this API now rejects; please route WAL recovery through these checks or share the duplicate-detection logic.Useful? React with 👍 / 👎.