feat(baselines): Add FedSaSync strategy by VictorHidalgoUCLM · Pull Request #7503 · flwrlabs/flower

VictorHidalgoUCLM · 2026-06-29T09:19:52Z

Issue

Description

Adds a new Flower baseline FedSaSync: a Semi-Asynchronous Federated Learning strategy in Flower. Experiments on CIFAR10 and MNIST under client heterogeneity.

Related issues/PRs

None.

Proposal

Explanation

Provides implementation for a Semi-Asynchronous aggregation algorithm in Flower.
Follows the official baseline template.
Evaluation using CIFAR10 and MNIST datasets with IID partitioning; several heterogeneous environments are simulated.

Checklist

Implement proposed change
Update documentation
Address LLM-reviewer comments, if applicable (e.g., GitHub Copilot)
Make CI checks pass
Ping maintainers on Slack (channel #contributions)

Any other comments?

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 8 comments.

Several changes, duplicated comments ignored. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Updated command examples to include federation configuration for 10 supernodes.

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Removed '.ruff_cache/**' from fab-exclude list.

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 7 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 43 out of 47 changed files in this pull request and generated 5 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ae265afb3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-30T11:59:47Z

+        train_clients = max(
+            int(self.fraction_train * int(len(list(grid.get_node_ids())))),
+            self.min_train_nodes,
+        )


Wait for nodes before fixing the sync degree

In deployments where start() runs before all SuperNodes have registered, this computes train_clients once from a partial grid.get_node_ids() result and then reuses that sync_deg for the entire run. For example, if only the minimum two nodes are visible at startup but the intended 10 clients connect moments later, configure_train can later send work to all 10 while send_and_receive_semiasync still stops after two replies, so the FedAvg/FedSaSync runs aggregate too few clients; wait for the intended training population or recompute this after nodes are available.

Useful? React with 👍 / 👎.

victor.hidalgo3@alu.uclm.es and others added 26 commits May 14, 2026 11:28

Add fedsasync baseline

5e6a713

Unmodified FedSaSync strategy injection to server_app

c23577f

Add utils functions for FedSaSync

a429f82

Overwrite configure_train() and start()

2ad78da

Add default config; support name usage on --run-config

45d9205

Add semiasync support

1d3f28c

Added fraction-slow support

7cdd829

Utils refactor

a38172f

Added dataset support (cifar10, mnist)

2fe2cbf

Add experiment automation

869ab5a

Add results to a csv for later graphing

508f6de

Add graph system (v0.1)

9cc9df0

Add random seed on the system for reproducibility

b62c527

First execution and graphing

c8e0240

Changed config system: on execution instead of .toml

fabe3f9

Added multiple log saving support

5e86192

Changed slow number client decision; add new metrics

80f239a

Execution results

eae5e06

Executions performed

bbba8cd

Version back

b78fca8

Results obtained for MNIST and CIFAR10

bb23a19

Formatting and tests passed

33b88a6

Updated medatadata

527acae

Updated medatadata

2902980

Added fab-exclude

934e4e8

Merge branch 'flwrlabs:main' into main

25ab221

Copilot AI review requested due to automatic review settings June 29, 2026 09:19

Copilot started reviewing on behalf of VictorHidalgoUCLM June 29, 2026 09:20 View session

VictorHidalgoUCLM marked this pull request as ready for review June 29, 2026 09:22

VictorHidalgoUCLM requested a review from chongshenng as a code owner June 29, 2026 09:22

Copilot AI reviewed Jun 29, 2026

View reviewed changes

VictorHidalgoUCLM and others added 4 commits June 29, 2026 13:28

Apply suggestions from code review

4bc0648

Several changes, duplicated comments ignored. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Modify README commands to include federation config

dfaafcd

Updated command examples to include federation configuration for 10 supernodes.

Add federation config to CIFAR-10 experiment script

3952ca9

Add federation config to MNIST experiment script

4eae645

VictorHidalgoUCLM requested a review from Copilot June 29, 2026 11:32

Copilot started reviewing on behalf of VictorHidalgoUCLM June 29, 2026 11:32 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread baselines/fedsasync/fedsasync/strategy.py

Comment thread baselines/fedsasync/fedsasync/strategy.py Outdated

Comment thread baselines/fedsasync/fedsasync/dataset.py

Comment thread baselines/fedsasync/_static/cifar10/FedAvg_fs0.csv

VictorHidalgoUCLM added 2 commits June 30, 2026 12:26

Modify round end condition to include empty message IDs

cdeadfb

Merge branch 'main' into main

387c5a4

VictorHidalgoUCLM requested a review from Copilot June 30, 2026 10:28

Copilot started reviewing on behalf of VictorHidalgoUCLM June 30, 2026 10:28 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread baselines/fedsasync/pyproject.toml

Comment thread baselines/fedsasync/_static/graphing.py

Comment thread baselines/fedsasync/fedsasync/strategy.py Outdated

VictorHidalgoUCLM and others added 2 commits June 30, 2026 12:55

Apply suggestions from code review

0e7bd41

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update fab-exclude in pyproject.toml

ee947e1

Removed '.ruff_cache/**' from fab-exclude list.

VictorHidalgoUCLM requested a review from Copilot June 30, 2026 10:59

Copilot started reviewing on behalf of VictorHidalgoUCLM June 30, 2026 10:59 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Apply suggestions from code review

a745782

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

VictorHidalgoUCLM requested a review from Copilot June 30, 2026 11:12

Copilot started reviewing on behalf of VictorHidalgoUCLM June 30, 2026 11:12 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread baselines/fedsasync/fedsasync/dataset.py

Comment thread baselines/fedsasync/fedsasync/strategy.py

Comment thread baselines/fedsasync/_static/graphing.py

Comment thread baselines/fedsasync/_static/graphing.py Outdated

Apply suggestions from code review

f9513ac

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

VictorHidalgoUCLM requested a review from Copilot June 30, 2026 11:19

Copilot started reviewing on behalf of VictorHidalgoUCLM June 30, 2026 11:19 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

VictorHidalgoUCLM and others added 2 commits June 30, 2026 13:53

Apply suggestions from code review

2d176e1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into main

0ae265a

VictorHidalgoUCLM marked this pull request as ready for review June 30, 2026 11:54

chatgpt-codex-connector Bot reviewed Jun 30, 2026

View reviewed changes

Uh oh!

Conversation

VictorHidalgoUCLM commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

Any other comments?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

VictorHidalgoUCLM commented Jun 29, 2026 •

edited

Loading