ci(framework): Update the update_version.py dev script#7490
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the framework’s dev/update_version.py script to derive the current version from framework/pyproject.toml and to expand/structure the set of versioned artifacts it can update (including Docker READMEs and uv.lock).
Changes:
- Add helpers for reading the current version, writing only when content changes, and bumping patch versions for example apps.
- Update version replacement logic to support single glob patterns, add
framework/uv.lock, and separate “next” vs “current” replacement sets. - Add logic to update Docker image README “supported tags” and nightly example tags.
Critical issues
- None found.
Simplicity/readability suggestions
- None beyond the inline comments.
Consistency concerns
- CLI flag naming:
--no_examplesreads broader than its actual behavior (it only skips example app pyproject updates). (Commented)
Should the PR be split?
- No.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62e46d501a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| content = re.sub( | ||
| rf"(`nightly`, `<version>\.dev<YYYYMMDD>` e\.g\. `)" | ||
| rf"{VERSION_PATTERN}\.dev\d{{8}}(`)", | ||
| rf"\g<1>{current_version}.dev{today}\g<2>", |
There was a problem hiding this comment.
When the post-release script runs, it rewrites pyproject.toml to next_version before the next nightly job; the nightly workflow then derives VERSION=$(uv version --short) after publish-nightly.sh appends .devYYYYMMDD to that rewritten version (framework/dev/publish-nightly.sh:36-37, .github/workflows/framework-release-nightly.yml:62-64). This README update still formats the nightly example with current_version, so after a 1.32.0 release the PR would bump the package to 1.33.0 but document 1.32.0.dev<date>, leaving the Docker README nightly tag examples one release cycle behind as soon as the nightly build publishes.
Useful? React with 👍 / 👎.
github-actions
Bot
added
the
Maintainer
No description provided.