-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(framework): Enable FastAPI to manage SuperLinkLifespan #7453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 59 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
db0a123
feat(framework): Add FastAPI scaffold
danieljanes f1d7292
Apply suggestions from code review
danieljanes 9747bf5
Merge branch 'main' into add-fastapi-scaffold
danieljanes c84ad18
Potential fix for pull request finding
danieljanes a15055a
Potential fix for pull request finding
danieljanes d4d0873
Potential fix for pull request finding
danieljanes 25d0bf8
Potential fix for pull request finding
danieljanes 6c5b37a
Merge branch 'main' into add-fastapi-scaffold
danieljanes 7356ba6
Fix imports
danieljanes dc9eb84
Merge branch 'main' into add-fastapi-scaffold
danieljanes 8ecf8fc
Merge branch 'main' into add-fastapi-scaffold
danieljanes 851403c
Merge branch 'main' into add-fastapi-scaffold
tanertopal 48bbe3d
Merge branch 'main' into add-fastapi-scaffold
danieljanes 35ae364
Merge branch 'main' into add-fastapi-scaffold
danieljanes 9b77027
Merge branch 'main' into add-fastapi-scaffold
tanertopal 5ccace9
Merge branch 'main' into add-fastapi-scaffold
danieljanes 7deab81
Introduce create_app()
danieljanes 5f3f62e
Add lifespan
danieljanes 5f0002b
refactor(framework): Move flower-superlink and flwr-serverapp entrypo…
danieljanes f8e53b8
Merge branch 'mv-cli-entrypoints' into add-fastapi-scaffold
danieljanes 003155f
Merge branch 'main' into mv-cli-entrypoints
danieljanes b79a692
Merge branch 'main' into mv-cli-entrypoints
danieljanes 7c68ae8
Add SuperLinkLifespan scaffold
danieljanes 3560ff2
Add SuperLinkLifespanConfig
danieljanes 0e13b05
Start FastAPI via flower-superlink
danieljanes ad5dda0
Minor edits
danieljanes 4985279
Add wait_until_background_thread_exits
danieljanes 383d10b
Add startup implementation
danieljanes cedfc05
Format
danieljanes 5ad6881
Complete SuperLinkLifespan
danieljanes 2f4dd78
Replace legacy startup with lifespan
danieljanes 747c38b
Add --disable-grpc-api
danieljanes 56dc409
Update FASTAPI.md
danieljanes 0c69ee7
Merge branch 'main' into mv-cli-entrypoints
danieljanes 44fc0c1
Merge branch 'main' into mv-cli-entrypoints
danieljanes 983c967
Merge branch 'main' into mv-cli-entrypoints
danieljanes e78ba7d
Merge branch 'mv-cli-entrypoints' into add-fastapi-scaffold
danieljanes 6529abc
Depend on fastapi without the standard extra
danieljanes 0451914
Update uv.lock
danieljanes fbe1d4a
Merge branch 'main' into add-fastapi-scaffold
danieljanes 76d1168
feat(framework): Create FastAPI scaffold
danieljanes dfaf1b3
Fix tests
danieljanes 0d88f83
Merge branch 'main' into create-fastapi-scaffold
danieljanes 8d61326
Merge branch 'create-fastapi-scaffold' into add-fastapi-scaffold
danieljanes 4d915cf
Improve health router
danieljanes 00bdc16
Update health router
danieljanes 8cdee18
Update health router
danieljanes ebfb63f
refactor(framework): Create SuperLinkLifespanConfig
danieljanes 87c1811
Merge branch 'create-superlink-lifespan-config' into add-fastapi-scaf…
danieljanes 39a9919
refactor(framework): Introduce SuperLinkLifespan
danieljanes 7c68770
Merge branch 'introduce-superlinklifespan' into add-fastapi-scaffold
danieljanes 349b8bb
Merge branch 'main' into introduce-superlinklifespan
danieljanes a73a321
Merge branch 'introduce-superlinklifespan' into add-fastapi-scaffold
danieljanes 49321ba
Merge branch 'main' into add-fastapi-scaffold
danieljanes cb015f1
Apply suggestion from @panh99
panh99 9f9864f
Apply suggestion from @panh99
panh99 9ea3728
Apply suggestion from @panh99
panh99 467b1e0
Merge branch 'main' into add-fastapi-scaffold
danieljanes d559804
Remove optional import, move constants
danieljanes 66c2be7
Merge branch 'main' into add-fastapi-scaffold
danieljanes 6f37b4e
Remove unused args
danieljanes ce84b95
Update import
danieljanes c2258fa
Merge branch 'main' into add-fastapi-scaffold
danieljanes 5afc044
Merge branch 'main' into add-fastapi-scaffold
danieljanes 91647c8
Apply suggestion from @panh99
panh99 4f7eb89
Apply suggestion from @panh99
panh99 cd37cbe
Merge branch 'main' into add-fastapi-scaffold
flwrmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new docs describe
flower-superlink --insecure --enable-http-apias the compatibility mode being used in prod, but this default makes the FastAPI server listen only on loopback. In container or Kubernetes deployments where traffic reaches the pod over its pod IP/Service,127.0.0.1is unreachable from outside the process, unlike the existing SuperLink API defaults that bind to0.0.0.0; operators following the documented command get no reachable HTTP API unless they know to add--host 0.0.0.0.Useful? React with 👍 / 👎.