fix(framework): Preserve ClientApp instruction message IDs#7392
Draft
psfoley wants to merge 1 commit into
Draft
Conversation
7b62624 to
8d672c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a message-correlation bug in the SuperNode ClientApp runtime by ensuring that inflated ClientApp input messages keep the transport instruction message ID (from the pulled protobuf Message) instead of using the inflated object-tree root ID. This allows reply messages to set reply_to_message_id to the exact ID the SuperNode uses for message-processing timing/tracking.
Changes:
- Update
pull_task_inputto setmessage.metadata.message_idfrom the transport/proto message (PullMessageresponse) rather than from the object-tree root ID. - Add a unit test verifying that
pull_task_inputpreserves the transport instruction message ID and that replies reference it viareply_to_message_id.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
framework/py/flwr/supernode/runtime/run_clientapp.py |
Sets inflated input message ID from the transport message metadata so replies correlate with SuperNode tracking. |
framework/py/flwr/supernode/runtime/run_clientapp_test.py |
Adds test coverage ensuring the preserved transport message ID is used for replies (reply_to_message_id). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Inflated messages were using the object-tree root ID as their message ID. Replies created from those messages then used the object ID as
reply_to_message_id, which did not match the SuperNode message-processing timer keyed by the original instruction message ID.Tests
CI is passing.