Skip to content

add close method #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominictarr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add close method #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78e3590
add close method
dominictarr May 9, 2019
58c0dba
Merge branch 'master' into close
dominictarr May 20, 2019
e1f29ce
don't change default cache size
dominictarr May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ module.exports = function (file, opts) {

var blockSize = opts.blockSize || 1024*16
var codec = opts.codec || {encode: id, decode: id, buffer: true}
var cache = opts.cache || Cache(1024)
var flags = opts.flags || 'a+'

@christianbundy christianbundy May 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we removed this in master on purpose but I can't remember why. Hmm.

@dominictarr dominictarr May 22, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember! it breaks your delete stuff. unfortunately there is no option that means "open a file for writing and reading and create the file if it does not exist" there is only error if it does not exist

@christianbundy christianbundy Jan 13, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that we should remove it from here? I don't remember, I can look into it (unless someone else beats me to it).

@dominictarr dominictarr Jan 13, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this patch should not change the file open flag, it's not about that.

var cache = opts.cache || Cache(8*1024)

@arj03 arj03 May 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make append a bit slower but make random a lot faster. Are you seeing the same @dominictarr?

Before:

append, 60189.786, 8.994, 602259, 89.996, 10.006
stream, 43594.04, 6.514, 435984, 65.15, 10.001
stream no cache, 50536.246, 7.551, 505413, 75.525, 10.001
stream10, 43835.232, 6.55, 438440, 65.517, 10.002
random, 27497.85, 4.109, 275006, 41.094, 10.001

After:

append, 57312.068, 8.561, 573178, 85.624, 10.001
stream, 44599.44, 6.662, 446039, 66.632, 10.001
stream no cache, 52688.831, 7.87, 526941, 78.717, 10.001
stream10, 44091.79, 6.586, 440962, 65.873, 10.001
random, 34874.812, 5.209, 348783, 52.103, 10.001

Also tested 16 that seems to be almost the same as 8.

@dominictarr dominictarr May 20, 2019

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I didn't mean to change the cache size. I'm gonna update PR to just not change that.

var offsetCodec = opts.offsetCodec || 32

var blocks = Blocks(file, blockSize, opts.flags, cache)
Expand Down
6 changes: 3 additions & 3 deletions inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,13 @@ module.exports = function (blocks, frame, codec, file, cache) {
)).catch((err) => cb(err))
.then(() => cb(null))
},
close: function (cb) {
cb()

@ahdinosaur ahdinosaur May 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to do anything or just provide a consistent api? if it's to make this module consistent with some interface, maybe add a comment saying "nothing to do when closing". anyway, seems innocent, but then there's other changes in this pull request that seem unrelated.

},
methods: {
del: 'async'
}
}
}





2 changes: 1 addition & 1 deletion bench.js → test/bench.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var FlumeLog = require('./')
var FlumeLog = require('../')
var codec = require('flumecodec')

require('bench-flumelog')(function () {
Expand Down
4 changes: 2 additions & 2 deletions test/flumelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ var create = require('../')
var testLog = require('test-flumelog')

function test(name, opts, cb) {
testLog(function () {
return create('/tmp/test_flumelog-offset_'+Date.now(), Object.assign({
testLog(function (filename) {
return create(filename, Object.assign({
blockSize: 1024,
codec: {
encode: function (v) {
Expand Down