Repository navigation
gem: remove copyright-header to bypass charlock_holmes build failure - #430
Conversation
`charlock_holmes` (0.7.9) fails to build its native extension on environments with GCC 16.1.1 and ICU 78 due to C++ compatibility issues. Since `copyright-header` is a development utility used for inserting copyright notices into source files, removing it has no impact on the core functionality of the application. This change unblocks `bundle update` on modern environments by removing the dependency chain: copyright-header -> github-linguist -> charlock_holmes.
|
@kenhys Thanks for the suggestion! I understand that grouping dependencies is generally a good practice. However, I realized that if we keep To keep the development setup as frictionless as possible for everyone, I decided to take it a step further and completely remove the I've updated the PR to remove it from both files. |
|
I plan to report the |
|
The issue already has been reported in brianmario/charlock_holmes#203 |
It sounds reasonable. |
kenhys
left a comment
There was a problem hiding this comment.
OK, let's make it forward.
|
Thanks |
charlock_holmes(0.7.9) fails to build its native extension on environments with GCC 16.1.1 and ICU 78 due to C++ compatibility issues.Since
copyright-headeris a development utility used for inserting copyright notices into source files, removing it has no impact on the core functionality of the application.This change unblocks
bundle updateon modern environments by removing the dependency chain: copyright-header -> github-linguist -> charlock_holmes.