fix: remove flowed claim#1322
Open
resolvicomai wants to merge 1 commit into
Open
Conversation
Member
|
conflicts with your own PR @resolvicomai |
0616b0b to
ac4938f
Compare
Contributor
Author
|
Thanks for flagging it. I rebased this PR on current Validation after rebase:
The branch is pushed again as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #1114. Plaintext-only messages now emit
Content-Type: text/plain; charset=UTF-8withoutformat=flowed, and both plaintext MIME paths share the same header writer. A regression test covers that the header no longer advertises flowed text while keeping quoted-printable encoding.Why?
The sender quoted-printable encodes the body but does not implement RFC 3676 format=flowed space-stuffing or soft line break semantics. Advertising
format=flowedcan make conforming clients reflow plain text incorrectly, especially quoted text.Validation:
go test ./sender -run TestWritePlainTextPartHeadersDoesNotClaimFormatFlowed -count=1go test ./sender -count=1go test ./...make lintgit diff --check