fix(storefront): capture the order id from the captured checkout - #42
Merged
Merged
Conversation
Complete Order Pickup and Get Order Receipt both address {{order_id}}, and
nothing in the Storefront collection ever set it — both sent the literal
placeholder and answered "No order found."
Capture checkout as order is the only request that creates a storefront order, so
it is the source. Both consumers run after it (fleetbase/fleetbase).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete Order PickupandGet Order Receiptboth address{{order_id}}, and nothing in the Storefront collection ever set it — both sent the literal placeholder and answered "No order found."Capture checkout as orderis the only request that creates a storefront order, so it is the source.Both consumers need to run after it; that ordering is in fleetbase/fleetbase. They also sit behind the whole checkout chain, so they will only pass once that chain does — if checkout fails they now fail for the checkout's reason rather than an unset variable, which is the more useful signal.
🤖 Generated with Claude Code