Skip to content

fix: close dashboard context panels on route exit - #332

Open
KenkoGeek wants to merge 1 commit into
fleetbase:mainfrom
KenkoGeek:fix/458-close-place-panel-on-navigation
Open

KenkoGeek wants to merge 1 commit into
fleetbase:mainfrom
KenkoGeek:fix/458-close-place-panel-on-navigation

Conversation

@KenkoGeek

Copy link
Copy Markdown

Summary

Close any open resource context panels when the FleetOps dashboard route is exited so a place details panel does not remain visible after navigating to Places.

The cleanup is attached to Ember's Route#deactivate hook, which only runs when the route is fully exited, rather than reacting to every route change.

Fixes fleetbase/fleetbase#458

Testing

  • Added a regression test for operations/orders/index route teardown
  • pnpm lint
  • pnpm build
  • pnpm exec ember test --test-port 0 --module "Unit | Route | operations/orders/index" --reporter tap

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FleetOps: Place sidebar doesn't close when clicking Places tab and allows multiple overlapping sidebars

1 participant