Skip to content

fix: preserve automation oncall update fields#23

Merged
ysyneu merged 1 commit into
mainfrom
codex/fix-automation-update-fields-20260703
Jul 3, 2026
Merged

fix: preserve automation oncall update fields#23
ysyneu merged 1 commit into
mainfrom
codex/fix-automation-update-fields-20260703

Conversation

@ysyneu

@ysyneu ysyneu commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add on-call incident trigger fields to AutomationRuleUpdateRequest
  • preserve nil vs false/empty partial-update semantics for update requests
  • add JSON round-trip regression coverage for the new fields

Verification

  • make check
  • go test ./... -run 'TestAutomationRuleUpdateRequestCanSendFalseValues|TestAutomationRuleUpdateRequestPreservesOncallIncidentTriggerFields' -count=1
  • go generate ./... && git diff --exit-code --stat

@ysyneu ysyneu added the bug Something isn't working label Jul 3, 2026
@ysyneu ysyneu merged commit 7f780bf into main Jul 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant