Skip to content

No I18N for HttpBadRequestExceptions#5410

Open
BertKoor wants to merge 4 commits into
fisharebest:mainfrom
BertKoor:premature_I18N
Open

No I18N for HttpBadRequestExceptions#5410
BertKoor wants to merge 4 commits into
fisharebest:mainfrom
BertKoor:premature_I18N

Conversation

@BertKoor

@BertKoor BertKoor commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

also a HttpException can be thrown before database connection is made: return a simple stack trace dump.

continuation of where #5393 left off

@fisharebest

Copy link
Copy Markdown
Owner

There are two distinct changes here.

  1. Remove I18N from validation messages. This seems sensible.

  2. Catch errors thrown during bootstrap. What sort of errors? How might I introduce such an error to test this?

@BertKoor

BertKoor commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

How might I introduce such an error to test this?

I tested it by letting the BadBotBlocker validate attribute client-eyepea instead of client-ip

$ip = Validator::attributes($request)->string('client-ip');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants