rendering of markdown code blocks lacked \n#5295
Open
BertKoor wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5295 +/- ##
============================================
+ Coverage 35.49% 35.77% +0.27%
+ Complexity 11211 11206 -5
============================================
Files 1166 1181 +15
Lines 48077 48023 -54
============================================
+ Hits 17065 17180 +115
+ Misses 31012 30843 -169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
\n\n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4841
Comment in the code after a fix for #4402:
There was a report in the forum of a rather long story of multiple paragraphs in a note being completely rendered on one single line. I traced back the cause to this
strtr($html, ["\n" => ''])function.Indented code blocks in markdown get rendered as
<pre><code></code></pre>, so newlines being kept in tact are then very relevant.I have chosen to remove only the last newline. That one is indeed redundant, and this then reduces impact on existing test cases.