Skip to content

feat(metrics): add optional id and properties fields to metrics output#5983

Open
not4s wants to merge 8 commits into
firecracker-microvm:mainfrom
not4s:feat/metrics-properties
Open

feat(metrics): add optional id and properties fields to metrics output#5983
not4s wants to merge 8 commits into
firecracker-microvm:mainfrom
not4s:feat/metrics-properties

test(metrics): add integration tests for id and properties

ec7e4cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project/firecracker succeeded Jun 30, 2026 in 0s

83.11% (target 80.00%)

View this Pull Request on Codecov

83.11% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.11%. Comparing base (573d249) to head (ec7e4cc).

Files with missing lines Patch % Lines
src/firecracker/src/main.rs 0.00% 2 Missing ⚠️
src/vmm/src/vmm_config/metrics.rs 93.75% 2 Missing ⚠️
src/vmm/src/logger/metrics.rs 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5983      +/-   ##
==========================================
+ Coverage   83.08%   83.11%   +0.02%     
==========================================
  Files         277      277              
  Lines       30201    30278      +77     
==========================================
+ Hits        25094    25166      +72     
- Misses       5107     5112       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.