Skip to content

fix: broken plugin exports#1489

Merged
jescalada merged 1 commit intomainfrom
1474-fix-broken-subpath-exports
Mar 31, 2026
Merged

fix: broken plugin exports#1489
jescalada merged 1 commit intomainfrom
1474-fix-broken-subpath-exports

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

@jescalada jescalada commented Mar 31, 2026

Fixes #1474. Replaces .npmignore with files allowlist in package.json

(Replaces #1480 which couldn't be promptly merged due to reviewer/last pusher issues)

Tested by running npm run build && npm pack and then, in a separate directory, installing the generated tarball and running node -e "require('@finos/git-proxy/plugin')".

@jescalada jescalada requested a review from a team as a code owner March 31, 2026 15:34
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 6529fc3
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69cbe98f9a863a0008b60e60

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 6529fc3.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (4e2eea8) to head (6529fc3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          68       68           
  Lines        4869     4869           
  Branches      888      888           
=======================================
  Hits         4366     4366           
  Misses        485      485           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada requested a review from coopernetes March 31, 2026 15:45
@jescalada
Copy link
Copy Markdown
Contributor Author

@coopernetes Does this work?

@coopernetes
Copy link
Copy Markdown
Contributor

Good to merge, thanks @jescalada !

@jescalada
Copy link
Copy Markdown
Contributor Author

Great!

@jescalada jescalada merged commit e788ab7 into main Mar 31, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-path exports broken in published tarball — .npmignore excludes dist/src/

2 participants