Skip to content

refactor: improve logging in src/proxy/processors, remove log-related stubs/spies in tests#1448

Merged
jescalada merged 10 commits intofinos:mainfrom
jescalada:1281-improve-processors-logging
Mar 16, 2026
Merged

refactor: improve logging in src/proxy/processors, remove log-related stubs/spies in tests#1448
jescalada merged 10 commits intofinos:mainfrom
jescalada:1281-improve-processors-logging

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

Fixes #1281, supersedes #1338

Also improves wording and log handling in general, and fixes log stubs in tests.

@jescalada jescalada requested a review from a team as a code owner March 8, 2026 13:59
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 8, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit c6c703e
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69b7effee5b4a7000887c812

@jescalada jescalada mentioned this pull request Mar 8, 2026
21 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 79.78723% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (d65c9b8) to head (c6c703e).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/config/ConfigLoader.ts 57.14% 3 Missing ⚠️
src/config/index.ts 40.00% 3 Missing ⚠️
src/db/file/users.ts 33.33% 2 Missing ⚠️
src/service/passport/activeDirectory.ts 50.00% 2 Missing ⚠️
src/service/passport/oidc.ts 50.00% 2 Missing ⚠️
src/service/routes/auth.ts 50.00% 2 Missing ⚠️
src/db/file/pushes.ts 50.00% 1 Missing ⚠️
src/db/file/repo.ts 50.00% 1 Missing ⚠️
src/plugin.ts 50.00% 1 Missing ⚠️
src/service/routes/repo.ts 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   89.71%   89.66%   -0.05%     
==========================================
  Files          68       68              
  Lines        4880     4869      -11     
  Branches      888      888              
==========================================
- Hits         4378     4366      -12     
- Misses        484      485       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada self-assigned this Mar 8, 2026
@jescalada
Copy link
Copy Markdown
Contributor Author

@kriswest I reimplemented #1338 in case we want to get the rc5 out ASAP. Only this and the any/as PR (#1323) remain! 👍🏼

Copy link
Copy Markdown

@re-vlad re-vlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple non-blocking comments

Copy link
Copy Markdown
Contributor

@andypols andypols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @jescalada I think we merge this in if you can resolve the conversation.

@jescalada jescalada requested a review from andypols March 16, 2026 11:57
Copy link
Copy Markdown
Contributor

@andypols andypols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jescalada jescalada merged commit 864559e into finos:main Mar 16, 2026
25 checks passed
@jescalada
Copy link
Copy Markdown
Contributor Author

Thanks! Will get the rc5 PR out in a second for our final round of testing before v2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve logging in processors/action chain

3 participants