Skip to content

removed div wrapper of elements (bug in Outlook 2007 and 2016 for Windows) and adjusted names of exported objects #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djadriano wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −25
Open

removed div wrapper of elements (bug in Outlook 2007 and 2016 for Windows) and adjusted names of exported objects #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f53690c
removed div wrapper of elements (bug in Outlook 2007 and 2016 for Win…
djadriano Feb 5, 2018
c361deb
adjusted names of exported objects (based on export layer name)
djadriano Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Slinky.sketchplugin/Contents/Sketch/Slinky.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions source/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion source/slinky/AppKit/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export function exportAssets(context: SketchContext, itemIds: string[], outputFo
+ ' "' + sketchFile + '"'
+ ' --scales=2'
+ ' --formats=png'
+ ' --use-id-for-name=yes'
+ ' --use-id-for-name=no'
+ ' --group-contents-only="yes"'
+ ' --save-for-web="no"'
+ ' --overwriting="yes"'
Expand Down
10 changes: 4 additions & 6 deletions source/slinky/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,11 @@ function createTable(layers: Layer[], size: TableSize){
// Prepare cell's content
const cellContent = (layers[cell].children.length === 0) ? getCellContent(layers[cell], size.depth, childTableSize) : createTable(layers[cell].children, childTableSize)

result += indent(size.depth + 2, `<td style="${cellStyle}" colspan="${colspan}" rowspan="${rowspan}">`)
result += indent(size.depth + 2, `<td style="${cellStyle} ${getCellStyle(layers[cell], childTableSize, {x: cellOffsetX, y: cellOffsetY})}" colspan="${colspan}" rowspan="${rowspan}">`)

if(layers[cell].url) result += indent(size.depth + 3, `<a href="${formatLink(layers[cell].url)}" style="text-decoration:none;">`)

result += indent(size.depth + 3, `<div style="${getCellStyle(layers[cell], childTableSize, {x: cellOffsetX, y: cellOffsetY})}">`)
result += cellContent
result += indent(size.depth + 3, `</div>`)

if(layers[cell].url) result += indent(size.depth + 3, `</a>`)

Expand Down Expand Up @@ -312,7 +310,7 @@ function getCellContent(layer: Layer, depth: number, size: TableSize){

function getCellStyle(layer: Layer, size: TableSize, offset: {x: number, y: number}){

let style = "display:block;"
let style = ""

let width = size.width
let height = size.height
Expand Down Expand Up @@ -483,14 +481,14 @@ function sketchToLayers(layerGroup: MSLayer[], offset?: {x: number, y: number},
border: borderWidth,
css: layerCSS,
content: (layer.class() == MSTextLayer) ? splitText(layer) : null,
source: (layer.isLayerExportable()) ? `assets/${unescape(layer.objectID())}@2x.png` : null,
source: (layer.isLayerExportable()) ? `assets/${unescape(layer.name())}.png` : null,
children: []
})

}

if(layer.isLayerExportable()){
assets.push(unescape(layer.objectID()))
assets.push(unescape(layer.name()))
}

}
Expand Down