[codex] Long-term: use SDK upload-cost planning in upload action#401
Draft
[codex] Long-term: use SDK upload-cost planning in upload action#401
Conversation
FilOzzy
added
team/filecoin-pin
rjan90
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the longer-term cleanup direction, not the tactical patch.
It replaces the upload action's custom deposit estimate with the SDK's multi-context upload cost calculation so funding stays aligned with the actual upload path.
What changed
synapse.storage.calculateMultiContextCosts(...)withCDNandproviderIdsinto funding so it matches the actual upload pathWhy
The upload action currently uses a simplified planner while the actual upload path is SDK-managed and multi-context. That makes it easy for pricing, copy-count, or dataset-creation rules to drift and cause underfunding bugs.
Using the SDK's own upload-cost calculation is the cleaner long-term fix for this class of issue.
Scope and tradeoff
This is a broader behavioral change than the short-term mitigation in #400.
It is valuable as the cleanup direction, but it is not the smallest patch to unblock the immediate failure.
Validation
pnpm run buildpnpm --filter filecoin-pin-upload-action-helper typecheckpnpm exec biome check upload-action/src/filecoin.js upload-action/src/types.ts upload-action/src/upload.js