fix: IPNI validation confirms provider in indexer response

[SgtPooki]

previously, validateIpniAdvertisement did not validate that the ipni advertisement existed for
the given provider. Now, we validate that the response includes the expected provider,
and allow consumers to pass extra providers (to support future multiple provider uploads)

some code inspired by #140

[Copilot]

Pull Request Overview

This PR enhances IPNI (InterPlanetary Network Indexer) advertisement validation to verify that specific storage providers have announced content, addressing a gap where the validation previously only checked if any provider advertised the CID. The implementation now validates that expected providers' multiaddrs are present in IPNI responses, with fallback to generic validation when provider information cannot be derived.

Key changes:

• Added provider-specific validation with multiaddr matching against expected providers
• Automatic provider detection from upload context with support for explicit provider specification
• Enhanced error messages showing which provider multiaddrs are missing from advertisements

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/core/utils/validate-ipni-advertisement.ts	Implements provider-specific IPNI validation with multiaddr conversion and matching logic
src/test/unit/validate-ipni-advertisement.test.ts	Adds comprehensive test coverage for provider validation scenarios and edge cases
src/core/upload/index.ts	Integrates provider validation by passing current provider info to IPNI validation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[BigLep]

I think I need to look again with a fresh head. This generally feels like a lot of code has gotten added and I'm wondering if there's ways to simplify (but not able to think clearly currently)

[SgtPooki]

@BigLep

I think I need to look again with a fresh head. This generally feels like a lot of code has gotten added and I'm wondering if there's ways to simplify (but not able to think clearly currently)

I simplified code a bit and inlined some things.. still +500 lines

[SgtPooki]

self review.. much better now..

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[BigLep]

Most comments are around terminology. We're validating the advertisement flow (not the advertisement itself). We do this by inspecting the ProviderResults/provider records.

I also was confused by why we have the ability for passing extra multiaddrs to validate.

[SgtPooki]

@BigLep most folks will call through this method, which will set expectedProviders to the correct thing (and to the multi-providers for multi-provider uploads once synapse-sdk is updated)

[SgtPooki]

FYI: CI was failing when I migrated to set operations because we only had tsconfig set to ES2022:

Error: src/core/utils/validate-ipni-advertisement.ts(195,60): error TS2550: Property 'intersection' does not exist on type 'Set<string>'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
Error: src/core/utils/validate-ipni-advertisement.ts(200,63): error TS2550: Property 'difference' does not exist on type 'Set<string>'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.

NodeJS Active LTS is 24 as of Oct 28 2025, and nodejs 22+ and all major browsers support Set.intersection and other set operations, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/intersection

We are already testing on CI for lts/* (24) and current (25), see https://nodejs.org/en/about/previous-releases#looking-for-the-latest-release-of-a-version-branch

I updated tsconfig to add ESNext.Collection, not wanting to take on engines and other changes in this PR

[BigLep]

Minor comments. Key thing is to get build passing. Approved otherwise.