Make RasterLayerSource.encodedTileTemplateUrl nullable - #136
Merged
Conversation
TileService layers (WMS, WMTS, ArcGIS) serve pre-rendered image tiles and have no encoded tile URL. Previously these layers were silently dropped by getLayers() because the Felt app's toSdkLayer couldn't construct a RasterLayerSource without an encodedTileTemplateUrl. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
axelson
commented
Jul 28, 2026
| { | ||
| "name": "@feltmaps/js-sdk", | ||
| "version": "1.9.0", | ||
| "version": "1.10.1", |
Contributor
Author
There was a problem hiding this comment.
This came along with a npm install and seems correct to include
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
axelson
added a commit
that referenced
this pull request
Jul 28, 2026
* Make RasterLayerSource.encodedTileTemplateUrl nullable TileService layers (WMS, WMTS, ArcGIS) serve pre-rendered image tiles and have no encoded tile URL. Previously these layers were silently dropped by getLayers() because the Felt app's toSdkLayer couldn't construct a RasterLayerSource without an encodedTileTemplateUrl. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * add a minimal claude.md * Regenerate API report and docs for nullable encodedTileTemplateUrl Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit 3c664d6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
RasterLayerSource.encodedTileTemplateUrlstring | null(wasstring).TileService layers (WMS, WMTS, ArcGIS) serve pre-rendered image tiles and have no encoded tile URL. The Felt app's
toSdkLayerwas silently dropping these layers fromgetLayers()because it couldn't construct aRasterLayerSourcewithout anencodedTileTemplateUrl.Also adds a minimal CLAUDE.md