Repository navigation
ci: run the Coveralls step on py3.10, skipped since #970 dropped py3.8 - #1075
Merged
Merged
Conversation
The Coveralls step only runs when matrix.python == '3.8', but feeluown#970 dropped 3.8 from the matrix (now 3.10 and 3.14), so the step has been skipped on every leg since then and coveralls.io has not received a master build after 2025-12-04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Coverallsstep in.github/workflows/build.ymlonly runs whenmatrix.python == '3.8'. #970 removed 3.8 from the matrix, which is now['3.10', '3.14']. Since then the step has been skipped on all six legs. coveralls.io's lastmasterbuild is 80fa035 from 2025-12-04 (55.3%), and the README badge still shows that build. PRs have also stopped getting the Coveralls coverage comment; the last one was on #968.This PR changes the literal to
'3.10'. 3.10 is now the oldest version in the matrix, the role 3.8 used to fill.To check:
masterrun, 35679395175:Coverallsisskippedin all sixtestjobs.curl -s 'https://coveralls.io/github/feeluown/FeelUOwn.json?branch=master'returns"created_at":"2025-12-04T15:24:47Z".make testandmake integration_teston all six legs: run 38949010416. The step is still skipped there because of thegithub.repositoryguard. A second fork run drops the guard and swaps the upload forcoveralls --output: run 38949010385. With that change the step runs ontest (ubuntu-latest, 3.10)only and builds a report for 257 source files (61.3% line coverage by its own count). A re-run of that job gave the same result.This PR's own CI uses the changed workflow, so the Coveralls comment should show up here. It will compare against the December build.
Generated with Claude Code (Claude Opus 5.5). The commit carries a
Co-Authored-Bytrailer.