-
Notifications
You must be signed in to change notification settings - Fork 5
Create Object API (Note/Article only for now)
#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2chanhaeng
wants to merge
9
commits into
main
Choose a base branch
from
feat/obj-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a9a1d54
Add ActivityPub object creation and outbox GraphQL support
2chanhaeng 6fd4cf4
Ignore local mise configuration
2chanhaeng 096a668
Cleanup AI genned
2chanhaeng d5594a4
Fix type errors reported by mise run check
2chanhaeng eef8ff0
Sort .gitignore
2chanhaeng b1cb022
Add tests hiding deleted nodes from node and nodes
2chanhaeng 21275b6
Filter deleted records
2chanhaeng 0a9e923
Add Create Dispatcher
2chanhaeng 445c991
Test the Create activity dispatcher
2chanhaeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ __generated__/ | |
|
|
||
| .pgdata/ | ||
|
|
||
| mise.local.toml | ||
| node_modules/ | ||
| packages/*/dist/ | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter hides deleted records only when they are the direct result of
nodeornodes. After marking an actor deleted,node(actorId)returns null, butnode(objectId) { ... on Object { actor { uuid } } }still returns that actor. It also remains reachable throughInstance.actors, and following itsobjectsconnection still returns content.What should happen to an actor's objects when the actor is soft-deleted? The relation queries and their counts should follow that decision. The foreign key's
ON DELETE CASCADEonly handles physical deletion. Please add regression coverage forObject.actor,Instance.actors, and the deleted actor'sobjectsconnection alongside the direct node lookups.