Remove dead opentracing reference from the confluent driver#685
Open
wbarnha wants to merge 1 commit into
Open
Conversation
ConfluentConsumerThread carried a commented-out '# _pending_rebalancing_spans: Deque[opentracing.Span]' attribute, copied from the aiokafka driver where it held real spans. The confluent driver never used it and does not import opentracing, so drop the stale comment -- the file now has no opentracing references at all.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 94.10% 94.06% -0.04%
==========================================
Files 102 102
Lines 11107 11107
Branches 1198 1198
==========================================
- Hits 10452 10448 -4
- Misses 556 558 +2
- Partials 99 101 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConfluentConsumerThreadcarried a commented-out attribute copied from the aiokafka driver:# _pending_rebalancing_spans: Deque[opentracing.Span]The confluent driver never used it and doesn't import
opentracing, so this stale comment was the file's only remainingopentracingreference. Removing it leavesfaust/transport/drivers/confluent.pywith zero opentracing references.Note: there was no actual
import opentracingto drop here — just this dead comment. Trivial, no runtime impact; flake8/black clean and the module still imports.Generated by Claude Code