add tensorflow as the KERAS_BACKEND for qkerasV3 tests#1499
Open
jmitrevs wants to merge 1 commit into
Open
Conversation
7 tasks
Contributor
|
Sounds like a bug from upstream in qkeras v3 to me. In keras v3, if |
Contributor
Author
|
However, we need a workaround till it is fixed. It seems better to explicitly set it vs to lock the version to an older version of qkeras3. |
Contributor
|
I would do version lock in this case |
Contributor
Author
|
I don't have a strong preference either way. Let's see what others say. I don't see a particular downside in setting the KERAS_BACKEND explicitly. |
Contributor
|
I can set the backend default to tensorflow in qkerasv3. |
Contributor
|
I fixed the default backend to tensorflow in qkerasv3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should fix the qkeras3 pytests issues introduced with qkeras_v3==1.2
Type of change
QKeras v3 1.2 needs to have the
KERAS_BACKENDenvironment variable set, so this sets it in the CI.Tests
This is a CI fix so it will only be visible in the CI. Compare with the qkeras3 pytest in #1497.
Checklist
pre-commiton the files I edited or added.