tests: add zsh completion test for Path arguments#1664
Conversation
|
Hi! This PR is currently blocked because it has no required label, and the workflows are awaiting maintainer approval. I think |
|
Hi @konuktor1-jpg, took a look at this on Windows with the project venv and ran the full file: Why the For a Scope Keeping this PR to zsh-only feels right — Bumping for visibility — looks ready as-is. |
svlandeg
left a comment
There was a problem hiding this comment.
Thank you for your contribution @konuktor1-jpg!
The original test arbitrarily picked bash just to be able to test the code path for a Path argument. If we're going to extend this test suite, we should do it for all shells and we should come up with a way to properly test the behaviour instead of just ensuring coverage. See also my comment here.
So TLDR, I think we shouldn't merge this as-is. Let me know if you'd like to work on extending this PR in line with my comment 👆
|
@ADiTyaRaj8969: your review reads like it's generated by AI - please refrain from leaving AI-generated reviews, especially without disclaimer. |
|
Sorry, ma'am. I will avoid AI styled writing in future reviews and make them more personal. |
Adds a small regression test for zsh path completion in
tests/test_completion/test_completion_path.py.The file already had a Bash completion test, but no zsh-specific assertion. This test checks that Path completion returns the
_filessignal for zsh.Tested locally with: