Skip to content

♻️ Remove redundant item deletion logic in backend/app/api/routes/users.py‎ #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raphaeltannous wants to merge 8 commits into
base: master
Choose a base branch
from
+71 −8
Open

♻️ Remove redundant item deletion logic in backend/app/api/routes/users.py‎ #2253

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da5a92d
Refactor user deletion logic in users.py
raphaeltannous Apr 5, 2026
752a5f2
🎨 Auto format and update with pre-commit
pre-commit-ci-lite[bot] Apr 5, 2026
ac0b261
Merge branch 'fastapi:master' into fix/cascade-delete-redundancy
raphaeltannous May 25, 2026
d1ad6e9
Add tests to check if items are delete after user deletion
raphaeltannous May 25, 2026
ee0d597
Remove already covered parts.
raphaeltannous May 25, 2026
97d6713
Add function to create a random item for a user
raphaeltannous May 25, 2026
aef8a96
Fix logic error for user random item creation
raphaeltannous May 25, 2026
8592e59
Refactor redundant random item creation
raphaeltannous May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions backend/app/api/routes/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Any

from fastapi import APIRouter, Depends, HTTPException
from sqlmodel import col, delete, func, select
from sqlmodel import col, func, select

from app import crud
from app.api.deps import (
Expand All @@ -13,7 +13,6 @@
from app.core.config import settings
from app.core.security import get_password_hash, verify_password
from app.models import (
Item,
Message,
UpdatePassword,
User,
Expand Down Expand Up @@ -225,8 +224,7 @@ def delete_user(
raise HTTPException(
status_code=403, detail="Super users are not allowed to delete themselves"
)
statement = delete(Item).where(col(Item.owner_id) == user_id)
session.exec(statement)

session.delete(user)
session.commit()
return Message(message="User deleted successfully")
Loading