Skip to content

docs: Add example to demonstrate module log level with ctor#222

Merged
tisonkun merged 1 commit into
fast:mainfrom
phungleson:module-log-with-ctor
May 20, 2026
Merged

docs: Add example to demonstrate module log level with ctor#222
tisonkun merged 1 commit into
fast:mainfrom
phungleson:module-log-with-ctor

Conversation

@phungleson
Copy link
Copy Markdown
Contributor

@phungleson phungleson commented Mar 25, 2026

Closes #218

@tisonkun tisonkun self-requested a review March 25, 2026 02:25
@tisonkun tisonkun changed the title Add example to demonstrate module log level with ctor docs: Add example to demonstrate module log level with ctor Mar 25, 2026
tisonkun
tisonkun approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I'm working on revising the API ( like #214 #215 ) and would see if we can improve the UX here.

@tisonkun tisonkun merged commit 38ad624 into fast:main May 20, 2026
10 checks passed
@tisonkun
Copy link
Copy Markdown
Contributor

tisonkun commented May 20, 2026

Perhaps make a dedicated logforth::filter::module::ModuleFilter and macro to librarize this pattern.

@phungleson phungleson deleted the module-log-with-ctor branch May 21, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamically change log level in the file

2 participants

@phungleson @tisonkun