Skip to content

Style/session manager list UI#2201

Merged
farion1231 merged 13 commits intofarion1231:mainfrom
Coconut-Fish:style/session-manager-list-ui
Apr 23, 2026
Merged

Style/session manager list UI#2201
farion1231 merged 13 commits intofarion1231:mainfrom
Coconut-Fish:style/session-manager-list-ui

Conversation

@Coconut-Fish
Copy link
Copy Markdown
Contributor

Summary / 概述

会话管理界面样式错误,修复了会话管理的样式

Related Issue / 关联 Issue

Fixes #

Screenshots / 截图

Before / 修改前 After / 修改后

|
74dca785410d65ad0c0693948910a517
|4ff52a02e6e79222a80b8811727c5930|

因为加入了下padding,导致设置->高级页面的保存会上移,所以修改了SettingsPage.tsx

Checklist / 检查清单

  • [√] pnpm typecheck passes / 通过 TypeScript 类型检查
  • [√] pnpm format:check passes / 通过代码格式检查
  • [未修改] cargo clippy passes (if Rust code changed) / 通过 Clippy 检查(如修改了 Rust 代码)
  • [未修改] Updated i18n files if user-facing text changed / 如修改了用户可见文本,已更新国际化文件

Copilot AI review requested due to automatic review settings April 20, 2026 10:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes styling/layout issues in the Session Manager list UI by adjusting global padding/scroll area behavior, with a small follow-up tweak to the Settings “Advanced” footer spacing.

Changes:

  • Adjust ScrollArea viewport inner wrapper sizing to prevent layout/width issues in scrollable lists.
  • Add app-level vertical padding and tweak Settings “Advanced” footer padding to compensate for the new layout.
  • Minor formatting change in useSettings (no functional change).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/hooks/useSettings.ts Formatting-only change to keep the dir-changed check on one line.
src/components/ui/scroll-area.tsx Forces Radix ScrollArea viewport inner wrapper to behave as full-width block content.
src/components/settings/SettingsPage.tsx Adjusts footer padding in the Advanced tab to account for new surrounding padding.
src/App.tsx Adds app-level vertical padding affecting overall layout spacing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/App.tsx Outdated
@Coconut-Fish
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner

@farion1231 farion1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢您的贡献,请查看一下是否有以下问题:
建议避免用根容器修复局部页面问题
PR 目标是修复会话管理列表样式,但 src/App.tsx 给根容器新增了 pb-4,这会影响所有主页面的可用高度和底部留白。后续又在 SettingsPage 里把 py-4 改成 pt-4 来抵消这个副作用,说明当前修复已经产生跨页面级联补偿。建议把底部留白或滚动修复收敛到 SessionManagerPage 的列表/卡片/滚动区域内。

共享 ScrollArea 修改需要更明确的边界
src/components/ui/scroll-area.tsx 通过 [&>div]:!block [&>div]:!min-w-0 [&>div]:!w-full 强制覆盖 Radix 内部 wrapper。当前仓库里 ScrollArea 主要用于 Session Manager 相关区域,实际风险有限,但这是基础组件层面的行为覆盖。建议确认是否可以在具体调用处包一层 min-w-0 w-full,或者至少说明为什么必须在 shared component 层修。

@Coconut-Fish
Copy link
Copy Markdown
Contributor Author

感谢您的贡献,请查看一下是否有以下问题: 建议避免用根容器修复局部页面问题 PR 目标是修复会话管理列表样式,但 src/App.tsx 给根容器新增了 pb-4,这会影响所有主页面的可用高度和底部留白。后续又在 SettingsPage 里把 py-4 改成 pt-4 来抵消这个副作用,说明当前修复已经产生跨页面级联补偿。建议把底部留白或滚动修复收敛到 SessionManagerPage 的列表/卡片/滚动区域内。

共享 ScrollArea 修改需要更明确的边界 src/components/ui/scroll-area.tsx 通过 [&>div]:!block [&>div]:!min-w-0 [&>div]:!w-full 强制覆盖 Radix 内部 wrapper。当前仓库里 ScrollArea 主要用于 Session Manager 相关区域,实际风险有限,但这是基础组件层面的行为覆盖。建议确认是否可以在具体调用处包一层 min-w-0 w-full,或者至少说明为什么必须在 shared component 层修。

增加底部留白是因为所有的页面都没有底部留白,我和我的朋友觉得这并不好看,我在win上几乎查看了所有的页面,仅在设置->高级的保存按钮发现了不和谐的留白,所以将SettingsPage 的样式修改了

image 不知道这样图片是否能直观的表示我的想法,在调用处包一层 min-w-0 w-full并不能修复这个问题,不能作用到所需的div上

@farion1231
Copy link
Copy Markdown
Owner

感谢您的贡献,请查看一下是否有以下问题: 建议避免用根容器修复局部页面问题 PR 目标是修复会话管理列表样式,但 src/App.tsx 给根容器新增了 pb-4,这会影响所有主页面的可用高度和底部留白。后续又在 SettingsPage 里把 py-4 改成 pt-4 来抵消这个副作用,说明当前修复已经产生跨页面级联补偿。建议把底部留白或滚动修复收敛到 SessionManagerPage 的列表/卡片/滚动区域内。
共享 ScrollArea 修改需要更明确的边界 src/components/ui/scroll-area.tsx 通过 [&>div]:!block [&>div]:!min-w-0 [&>div]:!w-full 强制覆盖 Radix 内部 wrapper。当前仓库里 ScrollArea 主要用于 Session Manager 相关区域,实际风险有限,但这是基础组件层面的行为覆盖。建议确认是否可以在具体调用处包一层 min-w-0 w-full,或者至少说明为什么必须在 shared component 层修。

增加底部留白是因为所有的页面都没有底部留白,我和我的朋友觉得这并不好看,我在win上几乎查看了所有的页面,仅在设置->高级的保存按钮发现了不和谐的留白,所以将SettingsPage 的样式修改了

image 不知道这样图片是否能直观的表示我的想法,在调用处包一层 min-w-0 w-full并不能修复这个问题,不能作用到所需的div上

感谢!

@farion1231 farion1231 merged commit 7bfe260 into farion1231:main Apr 23, 2026
2 checks passed
@Coconut-Fish Coconut-Fish deleted the style/session-manager-list-ui branch April 23, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants