Style/session manager list UI#2201
Conversation
…-Fish/cc-switch into style/add-provider.notes
…conut-Fish/cc-switch into style/session-manager-list-ui
There was a problem hiding this comment.
Pull request overview
Fixes styling/layout issues in the Session Manager list UI by adjusting global padding/scroll area behavior, with a small follow-up tweak to the Settings “Advanced” footer spacing.
Changes:
- Adjust
ScrollAreaviewport inner wrapper sizing to prevent layout/width issues in scrollable lists. - Add app-level vertical padding and tweak Settings “Advanced” footer padding to compensate for the new layout.
- Minor formatting change in
useSettings(no functional change).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/hooks/useSettings.ts | Formatting-only change to keep the dir-changed check on one line. |
| src/components/ui/scroll-area.tsx | Forces Radix ScrollArea viewport inner wrapper to behave as full-width block content. |
| src/components/settings/SettingsPage.tsx | Adjusts footer padding in the Advanced tab to account for new surrounding padding. |
| src/App.tsx | Adds app-level vertical padding affecting overall layout spacing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
farion1231
left a comment
There was a problem hiding this comment.
感谢您的贡献,请查看一下是否有以下问题:
建议避免用根容器修复局部页面问题
PR 目标是修复会话管理列表样式,但 src/App.tsx 给根容器新增了 pb-4,这会影响所有主页面的可用高度和底部留白。后续又在 SettingsPage 里把 py-4 改成 pt-4 来抵消这个副作用,说明当前修复已经产生跨页面级联补偿。建议把底部留白或滚动修复收敛到 SessionManagerPage 的列表/卡片/滚动区域内。
共享 ScrollArea 修改需要更明确的边界
src/components/ui/scroll-area.tsx 通过 [&>div]:!block [&>div]:!min-w-0 [&>div]:!w-full 强制覆盖 Radix 内部 wrapper。当前仓库里 ScrollArea 主要用于 Session Manager 相关区域,实际风险有限,但这是基础组件层面的行为覆盖。建议确认是否可以在具体调用处包一层 min-w-0 w-full,或者至少说明为什么必须在 shared component 层修。


Summary / 概述
会话管理界面样式错误,修复了会话管理的样式
Related Issue / 关联 Issue
无
Fixes #
Screenshots / 截图
|

|
|
因为加入了下padding,导致设置->高级页面的保存会上移,所以修改了SettingsPage.tsx
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查(如修改了 Rust 代码)