-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(proxy): 自动回切 — P1恢复时failback到主provider #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
954708775
wants to merge
5
commits into
farion1231:main
Choose a base branch
from
954708775:feat-auto-failback-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4a311c7
feat(proxy): 自动回切 — P1恢复时failback到主provider
e720c31
fix(fo-back): get_all_providers 失败时只跳过回切,不跳过 health update
8ade0c9
fix(fo-back): Pass AppHandle to FailoverSwitchManager for UI updates
6acc9bc
fix(fo-back): resolve review issues -竞态/吞错/空队列
834c48f
fix(fo-back): P1-A 关闭开关仍误切 + P1-B Closed≠恢复判断
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid returning from
record_resultwhen the optional failback metadata fetch fails. In this branch,Err(_) => return Ok(())exits before the normalupdate_provider_health_with_threshold(...)call, so successful requests are no longer written to provider health state and the DB read failure is silently masked. A transientget_all_providerserror should skip failback switching only, not bypass the core health-update path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
5eaf82c. Replacedreturn Ok(())with a labeledbreak 'failbacksoget_all_providersfailure only skips the failback path, not the health update. Thanks for catching this.