feat(opencode): add dedicated UI for model token limits (limit.context & limit.output)#2022
feat(opencode): add dedicated UI for model token limits (limit.context & limit.output)#2022wwminger wants to merge 1 commit intofarion1231:mainfrom
Conversation
…t & limit.output) Previously, there was no way to edit OpenCode model token limits in the UI. The 'limit' field was excluded from extra fields as a known/reserved key, but had no dedicated input. Users could only set limits via presets. Add a 'Token Limits' section with number inputs for context window and max output, placed between Model Properties and SDK Options in the expanded model details. Includes i18n for en/zh/ja locales.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72e157728e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (numValue === undefined && currentLimit.output === undefined) { | ||
| const { limit: _, ...rest } = model; |
There was a problem hiding this comment.
When the user clears context here, the branch deletes the whole limit object as soon as output is undefined, which also drops any existing limit.input (supported in OpenCode model metadata) or future limit fields. This causes silent config data loss for models imported from richer configs; the sibling handleModelLimitOutputChange has the same pattern. Only remove limit after checking that no keys remain after applying the edit.
Useful? React with 👍 / 👎.
3 participants
Summary
Previously, there was no way to edit OpenCode model token limits in the UI. The
limitfield was excluded from extra fields as a known/reserved key (OPENCODE_KNOWN_MODEL_KEYS), but had no dedicated input. Users could only set limits via presets.This PR adds a Token Limits section with number inputs for
limit.context(context window) andlimit.output(max output), placed between Model Properties and SDK Options in the expanded model details.Changes
OpenCodeFormFields.tsx: AddedhandleModelLimitContextChangeandhandleModelLimitOutputChangehandlers + Token Limits UI sectionsrc/i18n/locales/en.json,zh.json,ja.json: Added 6 i18n keys (tokenLimits, limitContext, limitOutput, limitContextPlaceholder, limitOutputPlaceholder, tokenLimitsHint)Testing
pnpm typecheckpassedScreenshots
The Token Limits section appears when expanding a model in the OpenCode provider form, allowing users to set context window and max output token limits directly.