Skip to content

Syk/client usage stats - #285

Open
itsoyou wants to merge 6 commits into
masterfrom
syk/client-usage-stats
Open

Syk/client usage stats#285
itsoyou wants to merge 6 commits into
masterfrom
syk/client-usage-stats

Conversation

@itsoyou

@itsoyou itsoyou commented Sep 11, 2026

Copy link
Copy Markdown
Member

SYN-124

Pull Request Checklist

  • In the description of your pull request:
    • Describe your change in a way that makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@itsoyou
itsoyou requested a review from a team as a code owner September 11, 2026 12:42
@itsoyou
itsoyou force-pushed the syk/client-usage-stats branch from c790f57 to 3195512 Compare September 11, 2026 12:43

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread synapse/storage/databases/main/metrics.py Outdated
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.92%. Comparing base (bd09672) to head (d486698).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
- Coverage   80.93%   80.92%   -0.01%     
==========================================
  Files         505      505              
  Lines       72978    72976       -2     
  Branches    11035    11035              
==========================================
- Hits        59062    59059       -3     
- Misses      10624    10625       +1     
  Partials     3292     3292              
Files with missing lines Coverage Δ
synapse/metrics/common_usage_metrics.py 100.00% <100.00%> (ø)
synapse/storage/databases/main/metrics.py 97.98% <100.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd09672...d486698. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsoyou
itsoyou marked this pull request as draft September 11, 2026 13:41
@itsoyou
itsoyou marked this pull request as ready for review September 11, 2026 14:32

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4450bf. Configure here.

Comment thread synapse/storage/databases/main/metrics.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant