Skip to content

fix: reject oauth logins when neither token references a user id - #106

Merged
FrenchGithubUser merged 1 commit into
mainfrom
tt/oauth-user-id
Sep 14, 2026
Merged

FrenchGithubUser merged 1 commit into
mainfrom
tt/oauth-user-id

Conversation

@FrenchGithubUser

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.60%. Comparing base (31474b4) to head (71d480b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   84.58%   84.60%   +0.01%     
==========================================
  Files          13       13              
  Lines         902      903       +1     
  Branches      163      164       +1     
==========================================
+ Hits          763      764       +1     
  Misses         85       85              
  Partials       54       54              
Files with missing lines Coverage Δ
synapse_token_authenticator/token_authenticator.py 71.65% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31474b4...71d480b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FrenchGithubUser
FrenchGithubUser marked this pull request as ready for review September 11, 2026 10:26
@FrenchGithubUser
FrenchGithubUser requested a review from a team as a code owner September 11, 2026 10:26
Comment thread tests/test_oauth.py
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread tests/test_oauth.py
Comment thread tests/test_oauth.py Outdated

@jason-famedly jason-famedly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@FrenchGithubUser
FrenchGithubUser added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 32b3785 Sep 14, 2026
6 checks passed
@FrenchGithubUser
FrenchGithubUser deleted the tt/oauth-user-id branch September 14, 2026 11:30
This was referenced Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants