Skip to content

fix: wrong if condition where rooms get removed from list even when includeLeave == true - #2475

Merged
krille-chan merged 1 commit into
mainfrom
krille/hotfix-include-leave-rooms-remove
Sep 2, 2026
Merged

fix: wrong if condition where rooms get removed from list even when includeLeave == true#2475
krille-chan merged 1 commit into
mainfrom
krille/hotfix-include-leave-rooms-remove

Conversation

@krille-chan

Copy link
Copy Markdown
Contributor

No description provided.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d3d3e51. Configure here.

Comment thread lib/src/client.dart
@krille-chan
krille-chan force-pushed the krille/hotfix-include-leave-rooms-remove branch from d3d3e51 to ef07a2b Compare September 2, 2026 12:30
@yurtemre7
yurtemre7 enabled auto-merge September 2, 2026 12:37
@yurtemre7
yurtemre7 disabled auto-merge September 2, 2026 12:38
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.38%. Comparing base (f63953b) to head (ef07a2b).

Files with missing lines Patch % Lines
lib/src/client.dart 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   60.39%   60.38%   -0.01%     
==========================================
  Files         162      162              
  Lines       20561    20564       +3     
==========================================
+ Hits        12417    12418       +1     
- Misses       8144     8146       +2     
Files with missing lines Coverage Δ
lib/src/client.dart 78.24% <40.00%> (-0.09%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63953b...ef07a2b. Read the comment docs.

@krille-chan
krille-chan merged commit 474c4d9 into main Sep 2, 2026
34 of 35 checks passed
@krille-chan
krille-chan deleted the krille/hotfix-include-leave-rooms-remove branch September 2, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants