chore: make autoRequestProfileForMissingUsers and getDisplayNameAndAvatarFromPrevContent configurable - #2472
Merged
Conversation
…atarFromPrevContent configurable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
=======================================
Coverage 60.44% 60.45%
=======================================
Files 162 162
Lines 20568 20572 +4
=======================================
+ Hits 12432 12436 +4
Misses 8136 8136
Continue to review full report in Codecov by Harness.
|
Member
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f03a1f6. Configure here.
krille-chan
deleted the
krille/make-displayname-fetching-configurable
branch
September 2, 2026 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Behavioral toggles default to existing behavior; risk is mainly misconfiguration (fewer profile fetches or missing display names for left users).
Overview
Adds two Client constructor flags so apps can tune how missing room members are resolved without changing call sites everywhere.
autoRequestProfileForMissingUsers(defaulttrue) drives whetherRoom.requestUserfalls back to the global profile when member state is empty.requestProfileis now optional; when omitted it uses that client setting.getDisplayNameAndAvatarFromPrevContent(defaulttrue) gates whetherUser.displayNameandUser.avatarUrlstill read fromprevContentfor non-joined members (e.g. left or banned). Turning it off stops using stale names/avatars from prior member events while keeping current defaults.Reviewed by Cursor Bugbot for commit f03a1f6. Bugbot is set up for automated code reviews on this repo. Configure here.