refactor: make voip.calls and voip.groupCalls simpler - #1796
Closed
td-famedly wants to merge 1 commit into
Closed
Conversation
Member
Author
|
missing currentGroupCID setter impl |
td-famedly
marked this pull request as draft
May 13, 2024 11:23
td-famedly
marked this pull request as draft
May 13, 2024 11:23
td-famedly
force-pushed
the
td/groupCallVoipId
branch
from
May 15, 2024 13:48
f010b51 to
3330956
Compare
td-famedly
changed the title
Member
Author
|
welp this evolved into a breaking change |
td-famedly
marked this pull request as ready for review
May 15, 2024 13:49
td-famedly
force-pushed
the
td/groupCallVoipId
branch
from
May 15, 2024 13:53
3330956 to
75a7d12
Compare
td-famedly
marked this pull request as draft
May 16, 2024 14:04
Member
Author
|
maybe redo again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/famedly/product-management/issues/1998
this does make stuff a bit simpler, but otoh not worth a breaking change considering matrix-org/matrix-spec-proposals#4143, will take a look at it later