Skip to content

chore(tests): pin cbor2 until we decide wrt exception handling#2640

Merged
vytas7 merged 1 commit into
falconry:masterfrom
vytas7:pin-cbor2
May 3, 2026
Merged

chore(tests): pin cbor2 until we decide wrt exception handling#2640
vytas7 merged 1 commit into
falconry:masterfrom
vytas7:pin-cbor2

Conversation

@vytas7
Copy link
Copy Markdown
Member

@vytas7 vytas7 commented May 3, 2026

It seems in the newly released 6.0.x, cbor2.CBORDecodeError is not a subclass of ValueError.

I have reported this upstream: agronholm/cbor2#299. Let's see what happens there; maybe we don't need to do anything, just wait for a new release. Otherwise we may need to adapt the tests, or stop testing cbor2 altogether.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e9e1d4b) to head (ae01705).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7976      7976           
  Branches      1102      1102           
=========================================
  Hits          7976      7976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vytas7 vytas7 merged commit b1b683a into falconry:master May 3, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant