Fix 32-bit zstdmt max job size allocation failure#4675
Open
danyalahmed1995 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4628.
Summary
Reduces the 32-bit zstdmt maximum job size from 512 MB / log 29 to 256 MB / log 28.
On 32-bit builds, the previous bound could allow a threaded compression configuration at max compression level to attempt an oversized allocation, matching the failure described in #4628.
This follows the issue reporter's diagnosis and proposed cap reduction.
Changes
ZSTDMT_JOBLOG_MAXon 32-bit builds from 29 to 28.ZSTDMT_JOBSIZE_MAXon 32-bit builds from 512 MB to 256 MB.ZSTD_c_jobSizereports the expected architecture-specific upper bound.Validation
git diff --checklinux/386using Debian testing:make cleanmake -j$(nproc)make checkThe temporary validation workflow was kept out of this PR branch.