Skip to content

fix: handle ftell failure before allocating input buffer in main.c #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 2 commits into
base: dev
Choose a base branch
from
+21 −2
Open

fix: handle ftell failure before allocating input buffer in main.c #4654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fee747
fix: V-002 security vulnerability
orbisai0security May 1, 2026
8f67f70
replacing asserts with explicit error handling
orbisai0security May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions contrib/externalSequenceProducer/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,33 @@ int main(int argc, char *argv[]) {
int const ret = fseek(f, 0, SEEK_END);
assert(ret == 0);
}
size_t const srcSize = ftell(f);
long const fileSize = ftell(f);
if (fileSize < 0) {
fprintf(stderr, "ERROR: ftell failed\n");
fclose(f);
ZSTD_freeCCtx(zc);
return 1;
}

size_t const srcSize = (size_t)fileSize;
if (srcSize == SIZE_MAX) {
fprintf(stderr, "ERROR: input file too large\n");
fclose(f);
ZSTD_freeCCtx(zc);
return 1;
}
{
int const ret = fseek(f, 0, SEEK_SET);
assert(ret == 0);
}

char* const src = malloc(srcSize + 1);
assert(src);
if (src == NULL) {
fprintf(stderr, "ERROR: allocation failed\n");
fclose(f);
ZSTD_freeCCtx(zc);
return 1;
}
{
size_t const ret = fread(src, srcSize, 1, f);
assert(ret == 1);
Expand Down