Fix StyleX CSS injection for Rspack unplugin#1745
Conversation
|
Hi @tmkx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@tmkx is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
What changed / motivation ?
Fixes the Rspack entry for
@stylexjs/unpluginso StyleX CSS injection hooks are registered through the Rspack-specific hook.unplugininvokes framework-specific hooks for Rspack viaplugin.rspack(compiler). The StyleX Rspack entry reused the Webpack hook registration asplugin.webpack(compiler), which meant the JS transform could run while the CSS asset injection hook was skipped.This updates the shared Webpack hook helper to accept the framework hook name, keeps
webpackas the default, and makes the Rspack entry register the hook asrspack.Pre-flight checklist
https://github.com/facebook/stylex/blob/main/.github/CONTRIBUTING.md