Skip to content

Fix StyleX CSS injection for Rspack unplugin#1745

Open
tmkx wants to merge 1 commit into
facebook:mainfrom
tmkx:fix-rspack-unplugin-css-injection
Open

Fix StyleX CSS injection for Rspack unplugin#1745
tmkx wants to merge 1 commit into
facebook:mainfrom
tmkx:fix-rspack-unplugin-css-injection

Conversation

@tmkx

@tmkx tmkx commented Jun 27, 2026

Copy link
Copy Markdown

What changed / motivation ?

Fixes the Rspack entry for @stylexjs/unplugin so StyleX CSS injection hooks are registered through the Rspack-specific hook.

unplugin invokes framework-specific hooks for Rspack via plugin.rspack(compiler). The StyleX Rspack entry reused the Webpack hook registration as plugin.webpack(compiler), which meant the JS transform could run while the CSS asset injection hook was skipped.

This updates the shared Webpack hook helper to accept the framework hook name, keeps webpack as the default, and makes the Rspack entry register the hook as rspack.

Pre-flight checklist

  • I have read the contributing guidelines
    https://github.com/facebook/stylex/blob/main/.github/CONTRIBUTING.md
  • Performed a self-review of my code

@tmkx tmkx requested review from mellyeliu and nmn as code owners June 27, 2026 17:57
@meta-cla

meta-cla Bot commented Jun 27, 2026

Copy link
Copy Markdown

Hi @tmkx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

@tmkx is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla

meta-cla Bot commented Jun 27, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant